[Add] TCP server to core MTP (HTTP/1.1 & HTTP/2) compatibility
All checks were successful
CI / checks (push) Successful in 5m29s

This commit is contained in:
Alex Emmet 2026-07-21 00:43:00 +02:00
commit 00f0aaeeff
21 changed files with 1627 additions and 677 deletions

View file

@ -12,6 +12,11 @@ mtp-crypto = { version = "0.2.0", path = "../crypto" }
bytes = "1"
http = "1"
tokio = { version = "1", features = ["io-util", "macros", "net", "rt", "sync", "time"] }
hyper = { version = "1", features = ["server", "http1", "http2"] }
hyper-util = { version = "0.1", features = ["server", "http1", "http2", "tokio"] }
http-body-util = "0.1"
tokio-rustls = "0.26"
tokio-stream = "0.1"
h3 = "0.0.8"
h3-quinn = { version = "0.0.10", features = ["datagram"] }
h3-webtransport = "0.1.2"
@ -24,6 +29,7 @@ rand = { version = "0.10.1", optional = true }
[dev-dependencies]
rcgen = "0.14"
hyper = { version = "1", features = ["client", "http2"] }
[features]
default = []

View file

@ -6,7 +6,9 @@ use std::fmt;
pub enum WebServerError {
Transport(CommunicationError),
WebTransport(String),
Tls(String),
Http(String),
PayloadTooLarge,
NotFound(String),
}
@ -15,7 +17,9 @@ impl fmt::Display for WebServerError {
match self {
Self::Transport(e) => write!(f, "transport error: {e}"),
Self::WebTransport(msg) => write!(f, "webtransport error: {msg}"),
Self::Tls(msg) => write!(f, "TLS error: {msg}"),
Self::Http(msg) => write!(f, "HTTP error: {msg}"),
Self::PayloadTooLarge => write!(f, "HTTP request body is too large"),
Self::NotFound(route) => write!(f, "route not found: {route}"),
}
}

341
mtp-webserver/src/h3.rs Normal file
View file

@ -0,0 +1,341 @@
use crate::{
HttpRequest, HttpResponse, Router, WebMTPConnection, WebServerError, WebServerMetrics,
transport::accept_web_connection,
};
use bytes::{Buf, Bytes};
use http::{Request, Response, StatusCode};
use mtp_host::HostConfig;
use std::{net::SocketAddr, sync::Arc, time::Duration};
use tokio::sync::{Semaphore, watch};
pub(crate) struct DriverConfig {
pub(crate) router: Router,
pub(crate) mtp_path: String,
pub(crate) max_request_body: usize,
pub(crate) request_timeout: Duration,
pub(crate) drain_timeout: Duration,
pub(crate) send_pongs: bool,
pub(crate) policy: mtp_transport::Policy,
pub(crate) host_config: Arc<HostConfig>,
pub(crate) metrics: Option<Arc<dyn WebServerMetrics>>,
}
pub(crate) async fn run_driver(
endpoint: quinn::Endpoint,
config: DriverConfig,
mtp_tx: tokio::sync::mpsc::Sender<Result<WebMTPConnection, mtp_host::AcceptError>>,
connection_semaphore: Arc<Semaphore>,
mut shutdown_rx: watch::Receiver<()>,
) {
let DriverConfig {
router,
mtp_path,
max_request_body,
request_timeout,
drain_timeout,
send_pongs,
policy,
host_config,
metrics,
} = config;
let mut connection_tasks = tokio::task::JoinSet::new();
loop {
tokio::select! {
biased;
_ = shutdown_rx.changed() => {
break;
}
incoming = endpoint.accept() => {
let Some(incoming) = incoming else {
break;
};
// Do not await capacity here: doing so would prevent this loop
// from observing shutdown while all connection slots are in use.
let permit = match connection_semaphore.clone().try_acquire_owned() {
Ok(permit) => permit,
Err(_) => {
tracing::debug!("rejecting QUIC connection at configured connection limit");
continue;
}
};
let router = router.clone();
let mtp_path = mtp_path.clone();
let mtp_tx = mtp_tx.clone();
let metrics = metrics.clone();
let host_config = host_config.clone();
connection_tasks.spawn(async move {
let _permit = permit;
let connect_start = std::time::Instant::now();
let connection = match incoming.await {
Ok(connection) => connection,
Err(error) => {
tracing::debug!(%error, "QUIC connection failed during handshake");
return;
}
};
let mut builder = h3::server::builder();
builder.enable_extended_connect(true);
builder.enable_webtransport(true);
builder.enable_datagram(true);
builder.max_webtransport_sessions(16);
let mut h3 = match builder
.build(h3_quinn::Connection::new(connection.clone()))
.await
{
Ok(connection) => connection,
Err(error) => {
tracing::debug!(%error, "HTTP/3 connection setup failed");
return;
}
};
if let Some(ref m) = metrics {
m.connection_accepted();
}
let remote_addr = connection.remote_address();
let mut tasks = tokio::task::JoinSet::new();
loop {
let resolver = match h3.accept().await {
Ok(Some(resolver)) => resolver,
Ok(None) => break,
Err(error) => {
tracing::debug!(%error, "HTTP/3 request accept failed");
break;
}
};
let (request, mut stream) = match resolver.resolve_request().await {
Ok(request) => request,
Err(error) => {
tracing::debug!(%error, "HTTP/3 request parse failed");
continue;
}
};
if request.method() == http::Method::CONNECT && request.uri().path() == mtp_path {
if request.extensions().get::<h3::ext::Protocol>()
!= Some(&h3::ext::Protocol::WEB_TRANSPORT)
{
let _ = stream
.send_response(
Response::builder()
.status(StatusCode::METHOD_NOT_ALLOWED)
.body(())
.unwrap(),
)
.await;
let _ = stream.finish().await;
continue;
}
let session = match h3_webtransport::server::WebTransportSession::accept(
request, stream, h3,
)
.await
{
Ok(session) => Arc::new(session),
Err(error) => {
tracing::debug!(%error, "WebTransport session accept failed");
return;
}
};
// The WebTransport session request driver must outlive this
// endpoint request task. Keep it detached so handing the MTP
// connection to the application does not wait for the session
// (which is intentionally an open-ended accept loop).
tokio::spawn(run_session_requests(
session.clone(),
router.clone(),
max_request_body,
request_timeout,
metrics.clone(),
remote_addr,
));
let result =
accept_web_connection(session, mtp_path, connection, send_pongs, policy, host_config.clone())
.await;
match mtp_tx.try_send(result) {
Ok(()) => {
// The detached session driver remains active while the
// delivered MTP connection keeps the session alive.
}
Err(tokio::sync::mpsc::error::TrySendError::Full(result)) => {
tracing::warn!("MTP connection backlog is full; dropping connection");
if let Ok(connection) = result {
connection.sender.close();
}
}
Err(tokio::sync::mpsc::error::TrySendError::Closed(result)) => {
if let Ok(connection) = result {
connection.sender.close();
}
}
}
return;
}
let router = router.clone();
let metrics = metrics.clone();
tasks.spawn(async move {
let path = request.uri().path().to_string();
let response = crate::http::run_request(
&path,
request_timeout,
metrics.as_ref(),
handle_http_request(request, &mut stream, &router, max_request_body, remote_addr),
).await;
if let Err(error) = write_response(&mut stream, response).await
&& let Some(metrics) = &metrics
{
metrics.error_occurred(&WebServerError::Http(format!("HTTP/3 response write failed: {error}")));
}
});
}
tasks.join_all().await;
if let Some(ref m) = metrics {
m.connection_closed(connect_start.elapsed(), "normal");
}
});
}
}
}
// --- Drain phase: wait for in-flight connections ---
endpoint.close(quinn::VarInt::from_u32(0), b"mtp-webserver shutdown");
let drain_start = std::time::Instant::now();
while !connection_tasks.is_empty() {
tokio::select! {
Some(result) = connection_tasks.join_next() => {
if let Err(e) = result {
tracing::warn!("Connection task panicked: {}", e);
}
}
_ = tokio::time::sleep(drain_timeout.saturating_sub(drain_start.elapsed())) => {
tracing::warn!(
"Drain timeout expired with {} connections still in flight",
connection_tasks.len()
);
break;
}
}
}
connection_tasks.shutdown().await;
}
async fn handle_http_request<S>(
request: Request<()>,
stream: &mut h3::server::RequestStream<S, Bytes>,
router: &Router,
max_request_body: usize,
remote_addr: SocketAddr,
) -> Result<HttpResponse, WebServerError>
where
S: h3::quic::BidiStream<Bytes>,
{
let (request, too_large) = read_request(request, stream, max_request_body, remote_addr)
.await
.map_err(|e| WebServerError::Http(format!("request body read failed: {e}")))?;
if too_large {
return Err(WebServerError::PayloadTooLarge);
}
Ok(crate::http::dispatch_request(request, router).await)
}
async fn run_session_requests(
session: Arc<h3_webtransport::server::WebTransportSession<h3_quinn::Connection, Bytes>>,
router: Router,
max_request_body: usize,
request_timeout: Duration,
metrics: Option<Arc<dyn WebServerMetrics>>,
remote_addr: SocketAddr,
) {
loop {
match session.accept_bi().await {
Ok(Some(h3_webtransport::server::AcceptedBi::Request(request, mut stream))) => {
let router = router.clone();
let metrics = metrics.clone();
tokio::spawn(async move {
let path = request.uri().path().to_string();
let response = crate::http::run_request(
&path,
request_timeout,
metrics.as_ref(),
handle_http_request(
request,
&mut stream,
&router,
max_request_body,
remote_addr,
),
)
.await;
if let Err(error) = write_response(&mut stream, response).await
&& let Some(metrics) = &metrics
{
metrics.error_occurred(&WebServerError::Http(format!(
"HTTP/3 response write failed: {error}"
)));
}
});
}
Ok(Some(h3_webtransport::server::AcceptedBi::BidiStream(_, _))) => {}
Ok(None) | Err(_) => break,
}
}
}
async fn read_request<S>(
request: Request<()>,
stream: &mut h3::server::RequestStream<S, Bytes>,
max_body: usize,
remote_addr: SocketAddr,
) -> Result<(HttpRequest, bool), h3::error::StreamError>
where
S: h3::quic::BidiStream<Bytes>,
{
let (parts, _) = request.into_parts();
let mut body = Vec::new();
let mut too_large = false;
while let Some(chunk) = stream.recv_data().await? {
if body.len().saturating_add(chunk.remaining()) > max_body {
too_large = true;
break;
}
body.extend_from_slice(chunk.chunk());
}
Ok((
HttpRequest {
method: parts.method,
uri: parts.uri,
headers: parts.headers,
body: (!body.is_empty()).then(|| Bytes::from(body)),
remote_addr,
},
too_large,
))
}
async fn write_response<S>(
stream: &mut h3::server::RequestStream<S, Bytes>,
response: HttpResponse,
) -> Result<(), h3::error::StreamError>
where
S: h3::quic::BidiStream<Bytes>,
{
let mut builder = Response::builder().status(response.status);
for (name, value) in &response.headers {
builder = builder.header(name, value);
}
stream
.send_response(builder.body(()).expect("valid HTTP response"))
.await?;
for chunk in response.body {
stream.send_data(chunk).await?;
}
if let Some(mut chunks) = response.stream {
while let Some(chunk) = chunks.recv().await {
stream.send_data(chunk).await?;
}
}
stream.finish().await
}

100
mtp-webserver/src/http.rs Normal file
View file

@ -0,0 +1,100 @@
use crate::{HttpRequest, HttpResponse, Router, WebServerError, WebServerMetrics};
use http::StatusCode;
use std::{future::Future, sync::Arc, time::Duration};
pub(crate) async fn dispatch_request(request: HttpRequest, router: &Router) -> HttpResponse {
let path = request.uri.path();
if let Some(handler) = router.handler(&request.method, path) {
return handler(request, HttpResponse::default()).await;
}
if let Some((handler, params)) = router.pattern_handler(&request.method, path) {
return handler(request, HttpResponse::default(), params).await;
}
if let Some(handler) = router.fallback_handler() {
return handler(request, HttpResponse::default()).await;
}
HttpResponse::new(StatusCode::NOT_FOUND)
}
pub(crate) async fn run_request<F>(
path: &str,
timeout: Duration,
metrics: Option<&Arc<dyn WebServerMetrics>>,
future: F,
) -> HttpResponse
where
F: Future<Output = Result<HttpResponse, WebServerError>>,
{
if let Some(metrics) = metrics {
metrics.request_started(path);
}
let started = std::time::Instant::now();
let response = match tokio::time::timeout(timeout, future).await {
Ok(Ok(response)) => response,
Ok(Err(error)) => {
let status = if matches!(error, WebServerError::PayloadTooLarge) {
StatusCode::PAYLOAD_TOO_LARGE
} else {
StatusCode::BAD_REQUEST
};
if let Some(metrics) = metrics {
metrics.error_occurred(&error);
}
HttpResponse::new(status)
}
Err(_) => {
let error = WebServerError::Http("request handler timed out".into());
if let Some(metrics) = metrics {
metrics.error_occurred(&error);
}
HttpResponse::new(StatusCode::REQUEST_TIMEOUT)
}
};
if let Some(metrics) = metrics {
metrics.request_completed(path, response.status.as_u16(), started.elapsed());
}
response
}
#[cfg(test)]
mod tests {
use super::*;
use http::{Method, Uri};
fn request(method: Method, uri: &'static str) -> HttpRequest {
HttpRequest {
method,
uri: Uri::from_static(uri),
headers: Default::default(),
body: None,
remote_addr: "127.0.0.1:1".parse().unwrap(),
}
}
#[tokio::test]
async fn shared_dispatch_preserves_precedence_and_ignores_query() {
let router = Router::new()
.route("/items", |_, response| async move {
response.status(StatusCode::ACCEPTED)
})
.unwrap()
.route_pattern("/{name}", |_, response, _| async move {
response.status(StatusCode::CREATED)
})
.unwrap()
.fallback(|_, response| async move { response.status(StatusCode::IM_A_TEAPOT) })
.unwrap();
assert_eq!(
dispatch_request(request(Method::GET, "/items?q=1"), &router)
.await
.status,
StatusCode::ACCEPTED
);
assert_eq!(
dispatch_request(request(Method::GET, "/other"), &router)
.await
.status,
StatusCode::CREATED
);
}
}

View file

@ -1,13 +1,16 @@
//! HTTP/3 routing primitives and the combined MTP web-server API.
//! HTTP routing primitives and the combined MTP web-server API.
//!
//! The public routing API is transport-independent. The HTTP/3 driver is
//! intentionally kept behind the crate's implementation boundary so callers
//! do not need to depend on a particular QUIC implementation.
mod error;
mod h3;
mod http;
mod router;
mod server;
mod stream;
mod tcp;
mod transport;
pub use error::WebServerError;
@ -15,7 +18,8 @@ pub use error::WebServerError;
pub use mtp_transport::TransportEvent;
pub use router::{DynamicHttpHandler, HttpHandler, RouteParams, Router, RouterError};
pub use server::{MTPWebServer, WebServerConfig, WebServerMetrics};
pub use stream::{Http3Request, Http3Response};
#[allow(deprecated)]
pub use stream::{Http3Request, Http3Response, HttpRequest, HttpResponse};
pub use transport::{
H3TransportConnection, H3TransportReceiver, H3TransportSender, WebMTPConnection,
WebMtpReceiver, WebMtpSender,

View file

@ -1,24 +1,24 @@
use crate::{Http3Request, Http3Response};
use crate::{HttpRequest, HttpResponse};
use http::Method;
use std::{collections::HashMap, future::Future, pin::Pin, sync::Arc};
/// Values captured from a parameterized route.
pub type RouteParams = HashMap<String, String>;
/// An asynchronous HTTP/3 route handler.
/// An asynchronous HTTP route handler.
pub type HttpHandler = Arc<
dyn Fn(Http3Request, Http3Response) -> Pin<Box<dyn Future<Output = Http3Response> + Send>>
dyn Fn(HttpRequest, HttpResponse) -> Pin<Box<dyn Future<Output = HttpResponse> + Send>>
+ Send
+ Sync,
>;
/// An asynchronous handler for a parameterized HTTP/3 route.
/// An asynchronous handler for a parameterized HTTP route.
pub type DynamicHttpHandler = Arc<
dyn Fn(
Http3Request,
Http3Response,
HttpRequest,
HttpResponse,
RouteParams,
) -> Pin<Box<dyn Future<Output = Http3Response> + Send>>
) -> Pin<Box<dyn Future<Output = HttpResponse> + Send>>
+ Send
+ Sync,
>;
@ -66,8 +66,8 @@ impl Router {
pub fn route<F, Fut>(self, path: impl Into<String>, handler: F) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response) -> Fut + Send + Sync + 'static,
Fut: Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse) -> Fut + Send + Sync + 'static,
Fut: Future<Output = HttpResponse> + Send + 'static,
{
self.route_inner(
None,
@ -83,8 +83,8 @@ impl Router {
handler: F,
) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response) -> Fut + Send + Sync + 'static,
Fut: Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse) -> Fut + Send + Sync + 'static,
Fut: Future<Output = HttpResponse> + Send + 'static,
{
self.route_inner(
Some(method),
@ -101,8 +101,8 @@ impl Router {
handler: F,
) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response, RouteParams) -> Fut + Send + Sync + 'static,
Fut: Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse, RouteParams) -> Fut + Send + Sync + 'static,
Fut: Future<Output = HttpResponse> + Send + 'static,
{
self.route_pattern_inner(
None,
@ -120,8 +120,8 @@ impl Router {
handler: F,
) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response, RouteParams) -> Fut + Send + Sync + 'static,
Fut: Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse, RouteParams) -> Fut + Send + Sync + 'static,
Fut: Future<Output = HttpResponse> + Send + 'static,
{
self.route_pattern_inner(
Some(method),
@ -132,8 +132,8 @@ impl Router {
pub fn fallback<F, Fut>(mut self, handler: F) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response) -> Fut + Send + Sync + 'static,
Fut: Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse) -> Fut + Send + Sync + 'static,
Fut: Future<Output = HttpResponse> + Send + 'static,
{
if self.fallback.is_some() {
return Err(RouterError::DuplicateFallback);
@ -307,7 +307,7 @@ mod tests {
response.status(StatusCode::NO_CONTENT)
})
.unwrap();
let request = Http3Request {
let request = HttpRequest {
method: Method::GET,
uri: Uri::from_static("/health"),
headers: Default::default(),
@ -315,7 +315,7 @@ mod tests {
remote_addr: "127.0.0.1:4433".parse().unwrap(),
};
let response =
router.handler(&Method::GET, "/health").unwrap()(request, Http3Response::default())
router.handler(&Method::GET, "/health").unwrap()(request, HttpResponse::default())
.await;
assert_eq!(response.status, StatusCode::NO_CONTENT);
assert!(router.handler(&Method::GET, "/missing").is_none());
@ -335,14 +335,14 @@ mod tests {
let (handler, params) = router
.pattern_handler(&Method::GET, "/api/get/user%2D123/profile.json")
.unwrap();
let request = Http3Request {
let request = HttpRequest {
method: Method::GET,
uri: Uri::from_static("/api/get/user%2D123/profile.json"),
headers: Default::default(),
body: Some(Bytes::new()),
remote_addr: "127.0.0.1:4433".parse().unwrap(),
};
let response = handler(request, Http3Response::default(), params).await;
let response = handler(request, HttpResponse::default(), params).await;
assert_eq!(response.body, vec![Bytes::from("user-123")]);
}
@ -380,14 +380,14 @@ mod tests {
let (handler, params) = router
.pattern_handler(&Method::GET, "/api/users/profile.json")
.unwrap();
let request = Http3Request {
let request = HttpRequest {
method: Method::GET,
uri: Uri::from_static("/api/users/profile.json"),
headers: Default::default(),
body: None,
remote_addr: "127.0.0.1:4433".parse().unwrap(),
};
let response = handler(request, Http3Response::default(), params).await;
let response = handler(request, HttpResponse::default(), params).await;
assert_eq!(response.status, StatusCode::CREATED);
}
}

View file

@ -1,14 +1,17 @@
use crate::{
Http3Request, Http3Response, Router, RouterError, WebMTPConnection, WebServerError,
transport::accept_web_connection,
HttpRequest, HttpResponse, Router, RouterError, WebMTPConnection, WebServerError,
h3::{DriverConfig, run_driver},
tcp::{TcpDriverConfig, run_driver as run_tcp_driver},
};
use bytes::{Buf, Bytes};
use http::{Method, Request, Response, StatusCode};
use http::Method;
use mtp_common::CommunicationError;
use mtp_host::HostConfig;
use rustls::pki_types::{PrivateKeyDer, pem::PemObject};
use std::{net::SocketAddr, sync::Arc, time::Duration};
use tokio::sync::{Semaphore, watch};
use tokio::{
net::TcpListener,
sync::{Semaphore, watch},
};
/// Observability hooks for the web server.
///
@ -23,7 +26,7 @@ pub trait WebServerMetrics: Send + Sync {
fn error_occurred(&self, _error: &WebServerError) {}
}
/// Configuration for the HTTP/3 server and MTP routing.
/// Configuration for the HTTPS/HTTP/3 server and MTP routing.
///
/// Use the builder methods to customise behaviour. All fields have sensible
/// defaults so `WebServerConfig::new()` gives a usable production-ready
@ -34,6 +37,9 @@ pub struct WebServerConfig {
pub(crate) mtp_path: String,
pub max_request_body: usize,
pub max_connections: usize,
pub serve_tcp_https: bool,
pub max_tcp_connections: usize,
pub tls_handshake_timeout: Duration,
pub request_timeout: Duration,
pub drain_timeout: Duration,
pub(crate) metrics: Option<Arc<dyn WebServerMetrics>>,
@ -52,6 +58,9 @@ impl WebServerConfig {
mtp_path: "/".to_string(),
max_request_body: 4 * 1024 * 1024,
max_connections: 256,
serve_tcp_https: true,
max_tcp_connections: 256,
tls_handshake_timeout: Duration::from_secs(10),
request_timeout: Duration::from_secs(30),
drain_timeout: Duration::from_secs(5),
metrics: None,
@ -60,8 +69,8 @@ impl WebServerConfig {
pub fn route<F, Fut>(mut self, path: impl Into<String>, handler: F) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = HttpResponse> + Send + 'static,
{
self.router = self.router.route(path, handler)?;
Ok(self)
@ -74,8 +83,8 @@ impl WebServerConfig {
handler: F,
) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = HttpResponse> + Send + 'static,
{
self.router = self.router.route_method(method, path, handler)?;
Ok(self)
@ -89,8 +98,8 @@ impl WebServerConfig {
handler: F,
) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response, crate::RouteParams) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse, crate::RouteParams) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = HttpResponse> + Send + 'static,
{
self.router = self.router.route_pattern(pattern, handler)?;
Ok(self)
@ -104,8 +113,8 @@ impl WebServerConfig {
handler: F,
) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response, crate::RouteParams) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse, crate::RouteParams) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = HttpResponse> + Send + 'static,
{
self.router = self.router.route_pattern_method(method, pattern, handler)?;
Ok(self)
@ -113,8 +122,8 @@ impl WebServerConfig {
pub fn fallback<F, Fut>(mut self, handler: F) -> Result<Self, RouterError>
where
F: Fn(Http3Request, Http3Response) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = Http3Response> + Send + 'static,
F: Fn(HttpRequest, HttpResponse) -> Fut + Send + Sync + 'static,
Fut: std::future::Future<Output = HttpResponse> + Send + 'static,
{
self.router = self.router.fallback(handler)?;
Ok(self)
@ -135,6 +144,21 @@ impl WebServerConfig {
self
}
pub fn serve_tcp_https(mut self, enabled: bool) -> Self {
self.serve_tcp_https = enabled;
self
}
pub fn max_tcp_connections(mut self, max: usize) -> Self {
self.max_tcp_connections = max;
self
}
pub fn tls_handshake_timeout(mut self, timeout: Duration) -> Self {
self.tls_handshake_timeout = timeout;
self
}
pub fn request_timeout(mut self, timeout: Duration) -> Self {
self.request_timeout = timeout;
self
@ -151,7 +175,7 @@ impl WebServerConfig {
}
}
/// An HTTP/3 server bound to MTP's configured address and certificate.
/// A combined HTTPS, HTTP/3, and WebTransport server.
///
/// One task owns the Quinn endpoint and dispatches all HTTP/3 requests. This
/// is the required ownership model for adding WebTransport MTP sessions on the
@ -160,52 +184,98 @@ pub struct MTPWebServer {
endpoint: quinn::Endpoint,
mtp_incoming: tokio::sync::mpsc::Receiver<Result<WebMTPConnection, mtp_host::AcceptError>>,
shutdown_tx: watch::Sender<()>,
_driver: Option<tokio::task::JoinHandle<()>>,
quic_driver: Option<tokio::task::JoinHandle<()>>,
tcp_driver: Option<tokio::task::JoinHandle<()>>,
local_addr: SocketAddr,
}
impl MTPWebServer {
pub async fn new(
host_config: HostConfig,
mut host_config: HostConfig,
web_config: WebServerConfig,
) -> Result<Self, CommunicationError> {
mtp_crypto::ensure_crypto_provider();
let certificates =
rustls::pki_types::CertificateDer::pem_slice_iter(&host_config.tls_fullchain)
.collect::<Result<Vec<_>, _>>()
.map_err(|_| CommunicationError::CertificateLoadFailed)?;
let key = PrivateKeyDer::from_pem_slice(&host_config.tls_key)
.map_err(|_| CommunicationError::CertificateParseFailed)?;
let tcp_listener = if web_config.serve_tcp_https {
let listener = TcpListener::bind(SocketAddr::new(host_config.ip, host_config.port))
.await
.map_err(|error| CommunicationError::Other(error.to_string()))?;
host_config.port = listener
.local_addr()
.map_err(|error| CommunicationError::Other(error.to_string()))?
.port();
Some(listener)
} else {
None
};
let tcp_tls = tcp_listener
.as_ref()
.map(|_| build_tcp_tls(&certificates, key.clone_key()))
.transpose()?;
let endpoint = build_endpoint(&host_config, certificates, key)?;
let local_addr = endpoint
.local_addr()
.map_err(|error| CommunicationError::Other(error.to_string()))?;
let host_config = Arc::new(host_config);
let endpoint = build_endpoint(&host_config)?;
let driver_endpoint = endpoint.clone();
// A completed MTP handshake must never block the endpoint driver just
// because the application is briefly slow to call `accept()`.
let (mtp_tx, mtp_incoming) = tokio::sync::mpsc::channel(web_config.max_connections.max(1));
let (shutdown_tx, shutdown_rx) = watch::channel(());
let connection_semaphore = Arc::new(Semaphore::new(web_config.max_connections));
let router = web_config.router.clone();
let metrics = web_config.metrics.clone();
let driver_config = DriverConfig {
router: web_config.router,
mtp_path: web_config.mtp_path,
router: web_config.router.clone(),
mtp_path: web_config.mtp_path.clone(),
max_request_body: web_config.max_request_body,
request_timeout: web_config.request_timeout,
drain_timeout: web_config.drain_timeout,
send_pongs: host_config.send_pongs,
policy: host_config.policy,
host_config,
metrics: web_config.metrics,
metrics: web_config.metrics.clone(),
};
let driver = tokio::spawn(run_driver(
let quic_driver = tokio::spawn(run_driver(
driver_endpoint,
driver_config,
mtp_tx,
connection_semaphore,
shutdown_rx,
shutdown_rx.clone(),
));
let tcp_driver = tcp_listener.zip(tcp_tls).map(|(listener, tls)| {
tokio::spawn(run_tcp_driver(
listener,
tls,
TcpDriverConfig {
router,
max_request_body: web_config.max_request_body,
request_timeout: web_config.request_timeout,
tls_handshake_timeout: web_config.tls_handshake_timeout,
drain_timeout: web_config.drain_timeout,
max_connections: web_config.max_tcp_connections,
metrics,
},
shutdown_rx,
))
});
Ok(Self {
endpoint,
mtp_incoming,
shutdown_tx,
_driver: Some(driver),
quic_driver: Some(quic_driver),
tcp_driver,
local_addr,
})
}
pub fn local_addr(&self) -> SocketAddr {
self.endpoint
.local_addr()
.expect("endpoint has a local address")
self.local_addr
}
pub async fn accept(&mut self) -> Result<Option<WebMTPConnection>, mtp_host::AcceptError> {
@ -222,7 +292,10 @@ impl MTPWebServer {
/// in-flight requests to complete before closing the endpoint.
pub async fn shutdown(mut self) {
let _ = self.shutdown_tx.send(());
if let Some(driver) = self._driver.take() {
if let Some(driver) = self.quic_driver.take() {
let _ = driver.await;
}
if let Some(driver) = self.tcp_driver.take() {
let _ = driver.await;
}
self.endpoint
@ -233,40 +306,33 @@ impl MTPWebServer {
pub async fn close(mut self) {
self.endpoint
.close(quinn::VarInt::from_u32(0), b"mtp-webserver shutdown");
if let Some(driver) = self._driver.take() {
if let Some(driver) = self.quic_driver.take() {
driver.abort();
let _ = driver.await;
}
if let Some(driver) = self.tcp_driver.take() {
driver.abort();
let _ = driver.await;
}
}
}
impl Drop for MTPWebServer {
fn drop(&mut self) {
if let Some(driver) = self._driver.take() {
if let Some(driver) = self.quic_driver.take() {
driver.abort();
}
if let Some(driver) = self.tcp_driver.take() {
driver.abort();
}
}
}
struct DriverConfig {
router: Router,
mtp_path: String,
max_request_body: usize,
request_timeout: Duration,
drain_timeout: Duration,
send_pongs: bool,
policy: mtp_transport::Policy,
host_config: Arc<HostConfig>,
metrics: Option<Arc<dyn WebServerMetrics>>,
}
fn build_endpoint(config: &HostConfig) -> Result<quinn::Endpoint, CommunicationError> {
mtp_crypto::ensure_crypto_provider();
let certificates = rustls::pki_types::CertificateDer::pem_slice_iter(&config.tls_fullchain)
.collect::<Result<Vec<_>, _>>()
.map_err(|_| CommunicationError::CertificateLoadFailed)?;
let key = PrivateKeyDer::from_pem_slice(&config.tls_key)
.map_err(|_| CommunicationError::CertificateParseFailed)?;
fn build_endpoint(
config: &HostConfig,
certificates: Vec<rustls::pki_types::CertificateDer<'static>>,
key: PrivateKeyDer<'static>,
) -> Result<quinn::Endpoint, CommunicationError> {
let mut tls = rustls::ServerConfig::builder()
.with_no_client_auth()
.with_single_cert(certificates, key)
@ -281,373 +347,14 @@ fn build_endpoint(config: &HostConfig) -> Result<quinn::Endpoint, CommunicationE
.map_err(|error| CommunicationError::Other(error.to_string()))
}
async fn run_driver(
endpoint: quinn::Endpoint,
config: DriverConfig,
mtp_tx: tokio::sync::mpsc::Sender<Result<WebMTPConnection, mtp_host::AcceptError>>,
connection_semaphore: Arc<Semaphore>,
mut shutdown_rx: watch::Receiver<()>,
) {
let DriverConfig {
router,
mtp_path,
max_request_body,
request_timeout,
drain_timeout,
send_pongs,
policy,
host_config,
metrics,
} = config;
let mut connection_tasks = tokio::task::JoinSet::new();
loop {
tokio::select! {
biased;
_ = shutdown_rx.changed() => {
break;
}
incoming = endpoint.accept() => {
let Some(incoming) = incoming else {
break;
};
// Do not await capacity here: doing so would prevent this loop
// from observing shutdown while all connection slots are in use.
let permit = match connection_semaphore.clone().try_acquire_owned() {
Ok(permit) => permit,
Err(_) => {
tracing::debug!("rejecting QUIC connection at configured connection limit");
continue;
}
};
let router = router.clone();
let mtp_path = mtp_path.clone();
let mtp_tx = mtp_tx.clone();
let metrics = metrics.clone();
let host_config = host_config.clone();
connection_tasks.spawn(async move {
let _permit = permit;
let connect_start = std::time::Instant::now();
let connection = match incoming.await {
Ok(connection) => connection,
Err(error) => {
tracing::debug!(%error, "QUIC connection failed during handshake");
return;
}
};
let mut builder = h3::server::builder();
builder.enable_extended_connect(true);
builder.enable_webtransport(true);
builder.enable_datagram(true);
builder.max_webtransport_sessions(16);
let mut h3 = match builder
.build(h3_quinn::Connection::new(connection.clone()))
.await
{
Ok(connection) => connection,
Err(error) => {
tracing::debug!(%error, "HTTP/3 connection setup failed");
return;
}
};
if let Some(ref m) = metrics {
m.connection_accepted();
}
let remote_addr = connection.remote_address();
let mut tasks = tokio::task::JoinSet::new();
loop {
let resolver = match h3.accept().await {
Ok(Some(resolver)) => resolver,
Ok(None) => break,
Err(error) => {
tracing::debug!(%error, "HTTP/3 request accept failed");
break;
}
};
let (request, mut stream) = match resolver.resolve_request().await {
Ok(request) => request,
Err(error) => {
tracing::debug!(%error, "HTTP/3 request parse failed");
continue;
}
};
if request.method() == http::Method::CONNECT && request.uri().path() == mtp_path {
if request.extensions().get::<h3::ext::Protocol>()
!= Some(&h3::ext::Protocol::WEB_TRANSPORT)
{
let _ = stream
.send_response(
Response::builder()
.status(StatusCode::METHOD_NOT_ALLOWED)
.body(())
.unwrap(),
)
.await;
let _ = stream.finish().await;
continue;
}
let session = match h3_webtransport::server::WebTransportSession::accept(
request, stream, h3,
)
.await
{
Ok(session) => Arc::new(session),
Err(error) => {
tracing::debug!(%error, "WebTransport session accept failed");
return;
}
};
// The WebTransport session request driver must outlive this
// endpoint request task. Keep it detached so handing the MTP
// connection to the application does not wait for the session
// (which is intentionally an open-ended accept loop).
tokio::spawn(run_session_requests(
session.clone(),
router.clone(),
max_request_body,
request_timeout,
metrics.clone(),
remote_addr,
));
let result =
accept_web_connection(session, mtp_path, connection, send_pongs, policy, host_config.clone())
.await;
match mtp_tx.try_send(result) {
Ok(()) => {
// The detached session driver remains active while the
// delivered MTP connection keeps the session alive.
}
Err(tokio::sync::mpsc::error::TrySendError::Full(result)) => {
tracing::warn!("MTP connection backlog is full; dropping connection");
if let Ok(connection) = result {
connection.sender.close();
}
}
Err(tokio::sync::mpsc::error::TrySendError::Closed(result)) => {
if let Ok(connection) = result {
connection.sender.close();
}
}
}
return;
}
let router = router.clone();
let metrics = metrics.clone();
tasks.spawn(async move {
let path = request.uri().path().to_string();
if let Some(ref m) = metrics {
m.request_started(&path);
}
let req_start = std::time::Instant::now();
let (response, status) = match tokio::time::timeout(
request_timeout,
handle_http_request(request, &mut stream, &router, max_request_body, remote_addr),
)
.await
{
Ok(Ok((resp, status))) => (resp, status),
Ok(Err(_)) => (
Http3Response::new(StatusCode::BAD_GATEWAY),
StatusCode::BAD_GATEWAY,
),
Err(_) => (
Http3Response::new(StatusCode::REQUEST_TIMEOUT),
StatusCode::REQUEST_TIMEOUT,
),
};
let _ = write_response(&mut stream, response).await;
if let Some(ref m) = metrics {
m.request_completed(&path, status.as_u16(), req_start.elapsed());
}
});
}
tasks.join_all().await;
if let Some(ref m) = metrics {
m.connection_closed(connect_start.elapsed(), "normal");
}
});
}
}
}
// --- Drain phase: wait for in-flight connections ---
endpoint.close(quinn::VarInt::from_u32(0), b"mtp-webserver shutdown");
let drain_start = std::time::Instant::now();
while !connection_tasks.is_empty() {
tokio::select! {
Some(result) = connection_tasks.join_next() => {
if let Err(e) = result {
tracing::warn!("Connection task panicked: {}", e);
}
}
_ = tokio::time::sleep(drain_timeout.saturating_sub(drain_start.elapsed())) => {
tracing::warn!(
"Drain timeout expired with {} connections still in flight",
connection_tasks.len()
);
break;
}
}
}
connection_tasks.shutdown().await;
}
async fn handle_http_request<S>(
request: Request<()>,
stream: &mut h3::server::RequestStream<S, Bytes>,
router: &Router,
max_request_body: usize,
remote_addr: SocketAddr,
) -> Result<(Http3Response, StatusCode), WebServerError>
where
S: h3::quic::BidiStream<Bytes>,
{
let (request, too_large) = read_request(request, stream, max_request_body, remote_addr)
.await
.map_err(|e| WebServerError::Http(format!("request body read failed: {e}")))?;
if too_large {
return Ok((
Http3Response::new(StatusCode::PAYLOAD_TOO_LARGE),
StatusCode::PAYLOAD_TOO_LARGE,
));
}
let path = request.uri.path().to_string();
match router.handler(&request.method, &path) {
Some(handler) => {
let response = handler(request, Http3Response::default()).await;
let status = response.status;
Ok((response, status))
}
None => match router.pattern_handler(&request.method, &path) {
Some((handler, params)) => {
let response = handler(request, Http3Response::default(), params).await;
let status = response.status;
Ok((response, status))
}
None => match router.fallback_handler() {
Some(handler) => {
let response = handler(request, Http3Response::default()).await;
let status = response.status;
Ok((response, status))
}
None => Ok((
Http3Response::new(StatusCode::NOT_FOUND),
StatusCode::NOT_FOUND,
)),
},
},
}
}
async fn run_session_requests(
session: Arc<h3_webtransport::server::WebTransportSession<h3_quinn::Connection, Bytes>>,
router: Router,
max_request_body: usize,
request_timeout: Duration,
metrics: Option<Arc<dyn WebServerMetrics>>,
remote_addr: SocketAddr,
) {
loop {
match session.accept_bi().await {
Ok(Some(h3_webtransport::server::AcceptedBi::Request(request, mut stream))) => {
let router = router.clone();
let metrics = metrics.clone();
tokio::spawn(async move {
let path = request.uri().path().to_string();
if let Some(ref m) = metrics {
m.request_started(&path);
}
let req_start = std::time::Instant::now();
let (response, status) = match tokio::time::timeout(
request_timeout,
handle_http_request(
request,
&mut stream,
&router,
max_request_body,
remote_addr,
),
)
.await
{
Ok(Ok((resp, status))) => (resp, status),
Ok(Err(_)) => (
Http3Response::new(StatusCode::BAD_GATEWAY),
StatusCode::BAD_GATEWAY,
),
Err(_) => (
Http3Response::new(StatusCode::REQUEST_TIMEOUT),
StatusCode::REQUEST_TIMEOUT,
),
};
let _ = write_response(&mut stream, response).await;
if let Some(ref m) = metrics {
m.request_completed(&path, status.as_u16(), req_start.elapsed());
}
});
}
Ok(Some(h3_webtransport::server::AcceptedBi::BidiStream(_, _))) => {}
Ok(None) | Err(_) => break,
}
}
}
async fn read_request<S>(
request: Request<()>,
stream: &mut h3::server::RequestStream<S, Bytes>,
max_body: usize,
remote_addr: SocketAddr,
) -> Result<(Http3Request, bool), h3::error::StreamError>
where
S: h3::quic::BidiStream<Bytes>,
{
let (parts, _) = request.into_parts();
let mut body = Vec::new();
let mut too_large = false;
while let Some(chunk) = stream.recv_data().await? {
if body.len().saturating_add(chunk.remaining()) > max_body {
too_large = true;
break;
}
body.extend_from_slice(chunk.chunk());
}
Ok((
Http3Request {
method: parts.method,
uri: parts.uri,
headers: parts.headers,
body: (!body.is_empty()).then(|| Bytes::from(body)),
remote_addr,
},
too_large,
))
}
async fn write_response<S>(
stream: &mut h3::server::RequestStream<S, Bytes>,
response: Http3Response,
) -> Result<(), h3::error::StreamError>
where
S: h3::quic::BidiStream<Bytes>,
{
let mut builder = Response::builder().status(response.status);
for (name, value) in &response.headers {
builder = builder.header(name, value);
}
stream
.send_response(builder.body(()).expect("valid HTTP response"))
.await?;
for chunk in response.body {
stream.send_data(chunk).await?;
}
if let Some(mut chunks) = response.stream {
while let Some(chunk) = chunks.recv().await {
stream.send_data(chunk).await?;
}
}
stream.finish().await
fn build_tcp_tls(
certificates: &[rustls::pki_types::CertificateDer<'static>],
key: PrivateKeyDer<'static>,
) -> Result<Arc<rustls::ServerConfig>, CommunicationError> {
let mut tls = rustls::ServerConfig::builder()
.with_no_client_auth()
.with_single_cert(certificates.to_vec(), key)
.map_err(|_| CommunicationError::CertificateLoadFailed)?;
tls.alpn_protocols = vec![b"h2".to_vec(), b"http/1.1".to_vec()];
Ok(Arc::new(tls))
}

View file

@ -3,9 +3,9 @@ use http::{HeaderMap, HeaderName, HeaderValue, Method, StatusCode, Uri};
use std::net::SocketAddr;
use tokio::sync::mpsc;
/// An owned HTTP/3 request passed to a route handler.
/// An owned HTTP request passed to a route handler.
#[derive(Clone, Debug)]
pub struct Http3Request {
pub struct HttpRequest {
pub method: Method,
pub uri: Uri,
pub headers: HeaderMap,
@ -13,15 +13,15 @@ pub struct Http3Request {
pub remote_addr: SocketAddr,
}
/// A buffered HTTP/3 response returned from a route handler.
pub struct Http3Response {
/// An HTTP response returned from a route handler.
pub struct HttpResponse {
pub status: StatusCode,
pub headers: HeaderMap,
pub body: Vec<Bytes>,
pub(crate) stream: Option<mpsc::Receiver<Bytes>>,
}
impl Http3Response {
impl HttpResponse {
pub fn new(status: StatusCode) -> Self {
Self {
status,
@ -68,19 +68,25 @@ impl Http3Response {
}
}
impl Default for Http3Response {
impl Default for HttpResponse {
fn default() -> Self {
Self::new(StatusCode::OK)
}
}
#[deprecated(note = "use HttpRequest")]
pub type Http3Request = HttpRequest;
#[deprecated(note = "use HttpResponse")]
pub type Http3Response = HttpResponse;
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn response_collects_headers_and_body_chunks() {
let response = Http3Response::new(StatusCode::CREATED)
let response = HttpResponse::new(StatusCode::CREATED)
.header("content-type", "text/plain")
.body("hello")
.body(" world");

202
mtp-webserver/src/tcp.rs Normal file
View file

@ -0,0 +1,202 @@
use crate::{HttpRequest, HttpResponse, Router, WebServerError, WebServerMetrics};
use bytes::Bytes;
use http::{Request, Response, header::CONTENT_LENGTH};
use http_body_util::{BodyExt, Full, StreamBody, combinators::BoxBody};
use hyper::{
body::{Frame, Incoming},
service::service_fn,
};
use hyper_util::{
rt::{TokioExecutor, TokioIo},
server::conn::auto::Builder,
};
use std::{convert::Infallible, sync::Arc, time::Duration};
use tokio::{
net::TcpListener,
sync::{Semaphore, watch},
task::JoinSet,
};
use tokio_rustls::TlsAcceptor;
use tokio_stream::{StreamExt, wrappers::ReceiverStream};
pub(crate) struct TcpDriverConfig {
pub router: Router,
pub max_request_body: usize,
pub request_timeout: Duration,
pub tls_handshake_timeout: Duration,
pub drain_timeout: Duration,
pub max_connections: usize,
pub metrics: Option<Arc<dyn WebServerMetrics>>,
}
pub(crate) async fn run_driver(
listener: TcpListener,
tls: Arc<rustls::ServerConfig>,
config: TcpDriverConfig,
mut shutdown_rx: watch::Receiver<()>,
) {
let permits = Arc::new(Semaphore::new(config.max_connections));
let mut tasks = JoinSet::new();
loop {
tokio::select! {
biased;
_ = shutdown_rx.changed() => break,
accepted = listener.accept() => {
let Ok((stream, remote_addr)) = accepted else { break };
let Ok(permit) = permits.clone().try_acquire_owned() else {
tracing::debug!(%remote_addr, "rejecting TCP connection at configured connection limit");
continue;
};
let acceptor = TlsAcceptor::from(tls.clone());
let router = config.router.clone();
let metrics = config.metrics.clone();
let timeout = config.request_timeout;
let body_limit = config.max_request_body;
let handshake_timeout = config.tls_handshake_timeout;
let connection_shutdown = shutdown_rx.clone();
tasks.spawn(async move {
let _permit = permit;
let started = std::time::Instant::now();
let tls_stream = match tokio::time::timeout(handshake_timeout, acceptor.accept(stream)).await {
Ok(Ok(stream)) => stream,
Ok(Err(error)) => {
report_error(metrics.as_ref(), WebServerError::Tls(error.to_string()));
return;
}
Err(_) => {
report_error(metrics.as_ref(), WebServerError::Tls("TLS handshake timed out".into()));
return;
}
};
if let Some(metrics) = &metrics { metrics.connection_accepted(); }
let service_metrics = metrics.clone();
let service = service_fn(move |request| {
serve_request(request, remote_addr, router.clone(), body_limit, timeout, service_metrics.clone())
});
let builder = Builder::new(TokioExecutor::new());
let connection = builder.serve_connection_with_upgrades(TokioIo::new(tls_stream), service);
tokio::pin!(connection);
tokio::select! {
result = &mut connection => {
if let Err(error) = result {
report_error(metrics.as_ref(), WebServerError::Http(format!("TCP HTTP connection failed: {error}")));
}
}
_ = wait_for_shutdown(connection_shutdown) => {
connection.as_mut().graceful_shutdown();
if let Err(error) = connection.await {
tracing::debug!(%error, "TCP HTTP connection ended during shutdown");
}
}
}
if let Some(metrics) = &metrics { metrics.connection_closed(started.elapsed(), "normal"); }
});
}
}
}
let drain = async { while tasks.join_next().await.is_some() {} };
if tokio::time::timeout(config.drain_timeout, drain)
.await
.is_err()
{
tasks.shutdown().await;
}
}
async fn wait_for_shutdown(mut shutdown_rx: watch::Receiver<()>) {
let _ = shutdown_rx.changed().await;
}
async fn serve_request(
request: Request<Incoming>,
remote_addr: std::net::SocketAddr,
router: Router,
max_body: usize,
timeout: Duration,
metrics: Option<Arc<dyn WebServerMetrics>>,
) -> Result<Response<BoxBody<Bytes, Infallible>>, Infallible> {
let path = request.uri().path().to_string();
let response = crate::http::run_request(&path, timeout, metrics.as_ref(), async move {
let request = read_request(request, remote_addr, max_body).await?;
Ok(crate::http::dispatch_request(request, &router).await)
})
.await;
Ok(into_hyper_response(response))
}
async fn read_request(
request: Request<Incoming>,
remote_addr: std::net::SocketAddr,
max_body: usize,
) -> Result<HttpRequest, WebServerError> {
let (parts, mut body) = request.into_parts();
if parts
.headers
.get(CONTENT_LENGTH)
.and_then(|value| value.to_str().ok())
.and_then(|value| value.parse::<usize>().ok())
.is_some_and(|length| length > max_body)
{
return Err(WebServerError::PayloadTooLarge);
}
let mut chunks = Vec::new();
let mut size = 0usize;
while let Some(frame) = body.frame().await {
let frame = frame
.map_err(|error| WebServerError::Http(format!("request body read failed: {error}")))?;
if let Ok(data) = frame.into_data() {
size = size.saturating_add(data.len());
if size > max_body {
return Err(WebServerError::PayloadTooLarge);
}
chunks.push(data);
}
}
let body = if chunks.is_empty() {
None
} else {
let mut combined = bytes::BytesMut::with_capacity(size);
for chunk in chunks {
combined.extend_from_slice(&chunk);
}
Some(combined.freeze())
};
Ok(HttpRequest {
method: parts.method,
uri: parts.uri,
headers: parts.headers,
body,
remote_addr,
})
}
fn into_hyper_response(mut response: HttpResponse) -> Response<BoxBody<Bytes, Infallible>> {
let mut builder = Response::builder().status(response.status);
if let Some(headers) = builder.headers_mut() {
*headers = response.headers;
}
let body = if let Some(stream) = response.stream.take() {
let stream = ReceiverStream::new(stream).map(|chunk| Ok(Frame::data(chunk)));
BodyExt::boxed(StreamBody::new(stream))
} else {
let length: usize = response.body.iter().map(Bytes::len).sum();
if let Some(headers) = builder.headers_mut()
&& !headers.contains_key(CONTENT_LENGTH)
{
headers.insert(CONTENT_LENGTH, length.into());
}
let mut body = bytes::BytesMut::with_capacity(length);
for chunk in response.body {
body.extend_from_slice(&chunk);
}
Full::new(body.freeze()).boxed()
};
builder.body(body).expect("valid HTTP response")
}
fn report_error(metrics: Option<&Arc<dyn WebServerMetrics>>, error: WebServerError) {
if let Some(metrics) = metrics {
metrics.error_occurred(&error);
}
}

View file

@ -1,9 +1,11 @@
use http::StatusCode;
use http::{Method, StatusCode};
use mtp_webserver::{MTPWebServer, WebServerConfig, WebServerError, WebServerMetrics};
use std::net::IpAddr;
use rustls::pki_types::{CertificateDer, ServerName, pem::PemObject};
use std::net::{IpAddr, SocketAddr};
use std::sync::Arc;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::time::Duration;
use tokio::io::{AsyncReadExt, AsyncWriteExt};
fn generate_self_signed_cert() -> (Vec<u8>, Vec<u8>) {
let key_pair = rcgen::KeyPair::generate().expect("failed to generate self-signed key pair");
@ -18,11 +20,52 @@ fn generate_self_signed_cert() -> (Vec<u8>, Vec<u8>) {
)
}
fn host_config(port: u16, cert: Vec<u8>, key: Vec<u8>) -> mtp_host::HostConfig {
mtp_host::HostConfig::new(IpAddr::V4(std::net::Ipv4Addr::LOCALHOST), port, cert, key)
}
async fn tls_connect(
addr: SocketAddr,
cert_pem: &[u8],
alpn: Vec<Vec<u8>>,
) -> tokio_rustls::client::TlsStream<tokio::net::TcpStream> {
let certs = CertificateDer::pem_slice_iter(cert_pem)
.collect::<Result<Vec<_>, _>>()
.unwrap();
let mut roots = rustls::RootCertStore::empty();
for cert in certs {
roots.add(cert).unwrap();
}
let mut config = rustls::ClientConfig::builder()
.with_root_certificates(roots)
.with_no_client_auth();
config.alpn_protocols = alpn;
let connector = tokio_rustls::TlsConnector::from(Arc::new(config));
connector
.connect(
ServerName::try_from("localhost").unwrap().to_owned(),
tokio::net::TcpStream::connect(addr).await.unwrap(),
)
.await
.unwrap()
}
async fn http1_request(addr: SocketAddr, cert_pem: &[u8], request: &str) -> Vec<u8> {
let mut stream = tls_connect(addr, cert_pem, vec![b"http/1.1".to_vec()]).await;
stream.write_all(request.as_bytes()).await.unwrap();
let mut response = Vec::new();
stream.read_to_end(&mut response).await.unwrap();
response
}
#[test]
fn config_builder_defaults() {
let config = WebServerConfig::new();
assert_eq!(config.max_request_body, 4 * 1024 * 1024);
assert_eq!(config.max_connections, 256);
assert!(config.serve_tcp_https);
assert_eq!(config.max_tcp_connections, 256);
assert_eq!(config.tls_handshake_timeout, Duration::from_secs(10));
assert_eq!(config.request_timeout, Duration::from_secs(30));
}
@ -30,10 +73,13 @@ fn config_builder_defaults() {
fn config_builder_chain() {
let config = WebServerConfig::new()
.max_connections(64)
.max_tcp_connections(32)
.tls_handshake_timeout(Duration::from_secs(2))
.max_request_body(1024)
.request_timeout(Duration::from_secs(5))
.mtp_path("/ws");
assert_eq!(config.max_connections, 64);
assert_eq!(config.max_tcp_connections, 32);
assert_eq!(config.max_request_body, 1024);
assert_eq!(config.request_timeout, Duration::from_secs(5));
}
@ -201,5 +247,301 @@ async fn graceful_shutdown_completes() {
let server = MTPWebServer::new(host_config, WebServerConfig::new())
.await
.unwrap();
let addr = server.local_addr();
server.shutdown().await;
assert!(tokio::net::TcpStream::connect(addr).await.is_err());
assert!(std::net::UdpSocket::bind(addr).is_ok());
}
#[tokio::test]
async fn tcp_and_udp_share_port_zero_assignment() {
let (cert, key) = generate_self_signed_cert();
let server = MTPWebServer::new(host_config(0, cert, key), WebServerConfig::new())
.await
.unwrap();
let addr = server.local_addr();
assert!(addr.port() > 0);
assert!(tokio::net::TcpStream::connect(addr).await.is_ok());
assert!(std::net::UdpSocket::bind(addr).is_err());
server.close().await;
}
#[tokio::test]
async fn tcp_conflict_fails_and_udp_only_does_not_claim_tcp() {
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
let addr = listener.local_addr().unwrap();
let (cert, key) = generate_self_signed_cert();
assert!(
MTPWebServer::new(host_config(addr.port(), cert, key), WebServerConfig::new())
.await
.is_err()
);
drop(listener);
let (cert, key) = generate_self_signed_cert();
let server = MTPWebServer::new(
host_config(addr.port(), cert, key),
WebServerConfig::new().serve_tcp_https(false),
)
.await
.unwrap();
let tcp = tokio::net::TcpListener::bind(addr).await.unwrap();
drop(tcp);
server.close().await;
}
#[tokio::test]
async fn close_and_drop_release_tcp_listener() {
let (cert, key) = generate_self_signed_cert();
let server = MTPWebServer::new(host_config(0, cert, key), WebServerConfig::new())
.await
.unwrap();
let addr = server.local_addr();
server.close().await;
assert!(tokio::net::TcpListener::bind(addr).await.is_ok());
let (cert, key) = generate_self_signed_cert();
let server = MTPWebServer::new(host_config(0, cert, key), WebServerConfig::new())
.await
.unwrap();
let addr = server.local_addr();
drop(server);
tokio::task::yield_now().await;
assert!(tokio::net::TcpListener::bind(addr).await.is_ok());
}
#[tokio::test]
async fn http1_routes_bodies_chunks_and_timeout() {
let (cert, key) = generate_self_signed_cert();
let config = WebServerConfig::new()
.max_request_body(8)
.request_timeout(Duration::from_millis(20))
.route_method(Method::POST, "/exact", |request, response| async move {
response.body(request.body.unwrap()).body("-tail")
})
.unwrap()
.route_pattern("/users/{user}", |request, response, params| async move {
response.body(format!(
"{}:{}",
params["user"],
request.uri.query().unwrap_or("")
))
})
.unwrap()
.route("/slow", |_, response| async move {
tokio::time::sleep(Duration::from_millis(100)).await;
response
})
.unwrap()
.fallback(|_, response| async move { response.status(StatusCode::IM_A_TEAPOT) })
.unwrap();
let server = MTPWebServer::new(host_config(0, cert.clone(), key), config)
.await
.unwrap();
let addr = server.local_addr();
let response = http1_request(addr, &cert, "POST /exact HTTP/1.1\r\nHost: localhost\r\nContent-Length: 4\r\nConnection: close\r\n\r\ndata").await;
assert!(String::from_utf8_lossy(&response).ends_with("data-tail"));
let response = http1_request(
addr,
&cert,
"GET /users/alice%2Dsmith?full=1 HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n",
)
.await;
assert!(String::from_utf8_lossy(&response).ends_with("alice-smith:full=1"));
let response = http1_request(
addr,
&cert,
"GET /exact HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n",
)
.await;
assert!(String::from_utf8_lossy(&response).starts_with("HTTP/1.1 418"));
let response = http1_request(addr, &cert, "POST /exact HTTP/1.1\r\nHost: localhost\r\nContent-Length: 9\r\nConnection: close\r\n\r\n123456789").await;
assert!(String::from_utf8_lossy(&response).starts_with("HTTP/1.1 413"));
let response = http1_request(
addr,
&cert,
"GET /slow HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n",
)
.await;
assert!(String::from_utf8_lossy(&response).starts_with("HTTP/1.1 408"));
server.close().await;
}
#[tokio::test]
async fn tls_negotiates_h2() {
let (cert, key) = generate_self_signed_cert();
let config = WebServerConfig::new()
.route("/h2", |_, response| async move { response.body("over-h2") })
.unwrap();
let server = MTPWebServer::new(host_config(0, cert.clone(), key), config)
.await
.unwrap();
let stream = tls_connect(server.local_addr(), &cert, vec![b"h2".to_vec()]).await;
assert_eq!(stream.get_ref().1.alpn_protocol(), Some(b"h2".as_slice()));
let (mut sender, connection) = hyper::client::conn::http2::handshake(
hyper_util::rt::TokioExecutor::new(),
hyper_util::rt::TokioIo::new(stream),
)
.await
.unwrap();
tokio::spawn(async move {
let _ = connection.await;
});
let request = http::Request::builder()
.uri("https://localhost/h2")
.body(http_body_util::Empty::<bytes::Bytes>::new())
.unwrap();
let response = sender.send_request(request).await.unwrap();
assert_eq!(response.status(), StatusCode::OK);
let body = http_body_util::BodyExt::collect(response.into_body())
.await
.unwrap()
.to_bytes();
assert_eq!(body, "over-h2");
server.close().await;
}
#[tokio::test]
async fn tcp_metrics_report_completion_and_errors() {
let (cert, key) = generate_self_signed_cert();
let metrics = Arc::new(TestMetrics::new());
let config = WebServerConfig::new()
.request_timeout(Duration::from_millis(10))
.with_metrics(metrics.clone())
.route("/slow", |_, response| async move {
tokio::time::sleep(Duration::from_millis(50)).await;
response
})
.unwrap();
let server = MTPWebServer::new(host_config(0, cert.clone(), key), config)
.await
.unwrap();
let response = http1_request(
server.local_addr(),
&cert,
"GET /slow HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n",
)
.await;
assert!(String::from_utf8_lossy(&response).starts_with("HTTP/1.1 408"));
assert_eq!(metrics.requests_started.load(Ordering::SeqCst), 1);
assert_eq!(metrics.requests_completed.load(Ordering::SeqCst), 1);
assert_eq!(metrics.errors.load(Ordering::SeqCst), 1);
server.close().await;
}
#[tokio::test]
async fn http1_keep_alive_and_streaming_work() {
let (cert, key) = generate_self_signed_cert();
let config = WebServerConfig::new()
.route("/one", |_, response| async move { response.body("one") })
.unwrap()
.route("/stream", |_, response| async move {
let (tx, rx) = tokio::sync::mpsc::channel(1);
tokio::spawn(async move {
tx.send(bytes::Bytes::from_static(b"first-")).await.unwrap();
tokio::time::sleep(Duration::from_millis(10)).await;
let _ = tx.send(bytes::Bytes::from_static(b"second")).await;
});
response.stream(rx)
})
.unwrap();
let server = MTPWebServer::new(host_config(0, cert.clone(), key), config)
.await
.unwrap();
let addr = server.local_addr();
let mut stream = tls_connect(addr, &cert, vec![b"http/1.1".to_vec()]).await;
stream.write_all(b"GET /one HTTP/1.1\r\nHost: localhost\r\n\r\nGET /one HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n").await.unwrap();
let mut response = Vec::new();
stream.read_to_end(&mut response).await.unwrap();
assert_eq!(
String::from_utf8_lossy(&response)
.matches("HTTP/1.1 200")
.count(),
2
);
let response = http1_request(
addr,
&cert,
"GET /stream HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n",
)
.await;
let response = String::from_utf8_lossy(&response);
assert!(response.contains("first-"));
assert!(response.contains("second"));
assert!(!response.to_ascii_lowercase().contains("content-length:"));
server.close().await;
}
#[tokio::test]
async fn shutdown_allows_active_request_within_drain_period() {
let (cert, key) = generate_self_signed_cert();
let entered = Arc::new(tokio::sync::Notify::new());
let handler_entered = Arc::clone(&entered);
let config = WebServerConfig::new()
.drain_timeout(Duration::from_millis(250))
.route("/work", move |_, response| {
let entered = Arc::clone(&handler_entered);
async move {
entered.notify_one();
tokio::time::sleep(Duration::from_millis(30)).await;
response.body("done")
}
})
.unwrap();
let server = MTPWebServer::new(host_config(0, cert.clone(), key), config)
.await
.unwrap();
let addr = server.local_addr();
let request = tokio::spawn(async move {
http1_request(
addr,
&cert,
"GET /work HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n",
)
.await
});
entered.notified().await;
server.shutdown().await;
assert!(String::from_utf8_lossy(&request.await.unwrap()).ends_with("done"));
}
#[tokio::test]
async fn shutdown_terminates_request_after_drain_period() {
let (cert, key) = generate_self_signed_cert();
let entered = Arc::new(tokio::sync::Notify::new());
let handler_entered = Arc::clone(&entered);
let config = WebServerConfig::new()
.drain_timeout(Duration::from_millis(20))
.route("/stuck", move |_, response| {
let entered = Arc::clone(&handler_entered);
async move {
entered.notify_one();
std::future::pending::<()>().await;
response
}
})
.unwrap();
let server = MTPWebServer::new(host_config(0, cert.clone(), key), config)
.await
.unwrap();
let addr = server.local_addr();
let request = tokio::spawn(async move {
let mut stream = tls_connect(addr, &cert, vec![b"http/1.1".to_vec()]).await;
stream
.write_all(b"GET /stuck HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n")
.await
.unwrap();
let mut response = Vec::new();
let _ = stream.read_to_end(&mut response).await;
response
});
entered.notified().await;
server.shutdown().await;
let response = tokio::time::timeout(Duration::from_millis(250), request)
.await
.expect("connection task survived drain timeout")
.unwrap();
assert!(!String::from_utf8_lossy(&response).contains("HTTP/1.1 200"));
}